[iceweasel] 111.0 Upstream updates and DDG fixes

1. Update patches according to changes from upstreams.
2. Rework DuckDuckGo patching to make it default search engine again and
   change method from GET to POST (see patch comment from
9004-FSDG-misc.patch)

1 files changed, 63 insertions, 1 deletions

diff --git a/libre/iceweasel/9004-FSDG-misc.patch b/libre/iceweasel/9004-FSDG-misc.patch
index 3af88e682..038b133bc 100644
--- a/libre/iceweasel/9004-FSDG-misc.patch
+++ b/libre/iceweasel/9004-FSDG-misc.patch
@@ -699,7 +699,7 @@ diff -u a/browser/components/newtab/lib/PanelTestProvider.jsm b/browser/componen
 -            },
 -            dismiss_button: {
 -              action: {
--                navigate: true,
+-                dismiss: true,
 -              },
 -            },
 -            ios: {
@@ -1064,6 +1064,68 @@ index b47e1c4a3f..fd62bfd3df 100644
 -- 
 2.39.0
 
+From a985a80d5df1226f4d7f84a72dd6c03b51fc68e4 Mon Sep 17 00:00:00 2001
+From: grizzlyuser <grizzlyuser@protonmail.com>
+Date: Sun, 12 Mar 2023 21:57:14 +0100
+Subject: [PATCH] FSDG: Change DuckDuckGo URL to DuckDuckGo HTML URL
+
+Some of JavaScript files from the regular DDG URL lack license info, and
+I couldn't find their freely licensed sources, so they can be considered
+nonfree.
+
+Replace the regular DDG URL with DDG HTML URL and rename the search
+engine accordingly. Currently, it looks like HTML version does not have
+any JS.
+
+Also:
+1. Change search method from GET to POST, because with GET, DDG HTML
+   will mangle URLs in search results, so that [1] becomes [2]. Not sure
+why that is done. Probably to avoid leaking search terms to visited
+sites (via Referer header?) at the cost of leaking clicked URLs to DDG,
+so this can still be a privacy concern.  BTW, POST is the default search
+method when searching directly from DDG HTML home page.
+
+2. Remove suspicious t=ffab URL parameter, because it can tell DDG that
+   this particular search extension is the origin of the search.`
+
+Private search engine that doesn't track its users, huh?
+
+[1] https://www.gnu.org/
+[2] https://duckduckgo.com/l/?uddg=https%3A%2F%2Fwww.gnu.org%2F&rut=b1ab1ab1a...
+---
+ .../components/search/extensions/ddg/manifest.json    | 11 +++++------
+ 1 file changed, 5 insertions(+), 6 deletions(-)
+
+diff --git a/browser/components/search/extensions/ddg/manifest.json b/browser/components/search/extensions/ddg/manifest.json
+index 56295197aa..475133c208 100644
+--- a/browser/components/search/extensions/ddg/manifest.json
++++ b/browser/components/search/extensions/ddg/manifest.json
+@@ -1,6 +1,6 @@
+ {
+-  "name": "DuckDuckGo",
+-  "description": "Search DuckDuckGo",
++  "name": "DuckDuckGo HTML",
++  "description": "Search DuckDuckGo HTML",
+   "manifest_version": 2,
+   "version": "1.3",
+   "browser_specific_settings": {
+@@ -18,10 +18,9 @@
+   "chrome_settings_overrides": {
+     "search_provider": {
+       "keyword": ["@duckduckgo", "@ddg"],
+-      "name": "DuckDuckGo",
+-      "search_url": "https://duckduckgo.com/",
+-      "search_form": "https://duckduckgo.com/?q={searchTerms}",
+-      "search_url_get_params": "t=ffab&q={searchTerms}",
++      "name": "DuckDuckGo HTML",
++      "search_url": "https://html.duckduckgo.com/html/",
++      "search_url_post_params": "q={searchTerms}",
+       "suggest_url": "https://ac.duckduckgo.com/ac/",
+       "suggest_url_get_params": "q={searchTerms}&type=list"
+     }
+-- 
+2.39.2
+
 diff --git a/browser/app/permissions b/browser/app/permissions
 index 5bc1d66fcd..a8252ab784 100644
 --- a/browser/app/permissions